Product articles SQL Prompt SQL Code Analysis
SQL Prompt code analysis: avoiding the…

12 July 2018

1 Comment

Guest post

This is a guest post from Phil Factor. Phil Factor (real name withheld to protect the guilty), aka Database Mole, has 30 years of experience with database-intensive applications.

Despite having once been shouted at by a furious Bill Gates at an exhibition in the early 1980s, he has remained resolutely anonymous throughout his career.

He is a regular contributor to Simple Talk and SQLServerCentral.

12 July 2018

1 Comment

SQL Prompt code analysis: avoiding the old-style TOP clause (ST006)

If you want to use TOP with an expression or subquery, or in INSERT, UPDATE, MERGE, and DELETE statements, then use of brackets is required, so it's a good habit to adopt everywhere.

Guest post

This is a guest post from Phil Factor. Phil Factor (real name withheld to protect the guilty), aka Database Mole, has 30 years of experience with database-intensive applications.

Despite having once been shouted at by a furious Bill Gates at an exhibition in the early 1980s, he has remained resolutely anonymous throughout his career.

He is a regular contributor to Simple Talk and SQLServerCentral.

The syntax of the TOP clause insists on a bracketed, or parenthesized, expression as its first argument, so that TOP 34 should, strictly speaking be TOP (34), although if you are just supplying a numeric constant, such as 34, as an argument then either style will work. Early incarnations of TOP could use only a constant value, so the parentheses weren’t necessary, and the old, bracket-less style is still supported so that code written in previous versions of SQL Server will still work.

However, TOP has come a long way since then, and now supports use of an expression, such as (@Rows*2), or a subquery. In these cases, the brackets are necessary. They are also required when TOP is used in INSERT, UPDATE, MERGE, and DELETE statements, so it is a habit worth adopting everywhere. SQL Prompt will raise one of its ‘code style violation’ warnings (ST006) when it spots use of the old-style syntax.

SQL Prompt code analysis style rule ST006

TOP examples

Imagine we want the top ten best performing customers at AdventureWorks.

Listing 1: TOP 10 WITH TIES

This old-style TOP 10 WITH TIES syntax will run quite happily, even though strictly we should be using (10).

results from a top 10 with ties query

However, if you are using a constant scalar subquery, the top 0.1% of all customers in this example, then the parentheses are required.

Listing 2: TOP 0.1% of customers

Using OFFSET and FETCH NEXT as an alternative

If you don’t like being nagged about doing brackets you can happily use OFFSET and FETCH NEXT instead, which don’t require them, although it’s a bit more long-winded.

Listing 3: Using OFFESET and FETCH NEXT

You can’t do ties, but you can specify a variable, parameter, or even constant scalar subquery as an argument to the OFFSET and FETCH NEXT, and you don’t need brackets unless you use a subquery.

Listing 4: Using FETCH NEXT with a subquery

Conclusions

There are worse sins in SQL that leaving out brackets in the parameter to a TOP statement. Strangely, I’ve always felt a bit uncomfortable about leaving them out because it is useful to be reminded of the power of the TOP clause nowadays. It is a long way from the old days of having to temporarily set the ROWCOUNT to the number of rows you wanted returned!

Share this post.

Share on FacebookShare on Google+Share on LinkedInTweet about this on Twitter
  • Another great post Phil! Even learned some new things myself. 🙂

You may also like

  • Article

    How we used your feedback to improve parentheses formatting in SQL Prompt 8.1

    After we released SQL Prompt 8, our priority was to continue to support the new formatting engine by fixing any bugs and reviewing feedback from users. One of the recurring patterns we noticed in your feedback regarded parentheses formatting. Some of you told us you couldn’t format the parentheses exactly the way you wanted to.

  • Article

    3 Results Grid features SQL Prompt brings to SSMS

    You may not have heard about it yet, but three helpful features were recently added to SQL Prompt that are activated when you right-click on the Results Grid in SQL Server Management Studio (SSMS). 1. Copy as IN clause This feature is available when you have values from a single column selected. You can select

  • Article

    When to use the SELECT…INTO statement (PE003)

    SELECT…INTO is a useful shortcut for development work, especially for creating temporary tables. However, it no longer has a clear performance advantage and should be avoided in production code. It is better to use a CREATE TABLE statement, where you can specify constraints and datatypes in advance, making it less likely that inconsistencies will sneak into the data.

  • Article

    How to format a set of SQL scripts using SQL Prompt

    Any database developer or DBA who spends much of their working week staring at SQL code quickly becomes set in their ways. They like to see the code laid out in a very particular way. They will struggle to look at, let alone digest and understand, code formatted in a ‘foreign’ style. It’s also rare

  • Forums

    SQL Prompt Forum

    Write, format, and refactor SQL effortlessly